Add support for CLI flag for mTLS client certificate key passphrase #5494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request does not have a backport label. Could you fix it @AndersonQ? 🙏
|
AndersonQ
force-pushed
the
5489-client-cert-key-passphrase
branch
2 times, most recently
from
5c9c606 to
3351e32
Compare
AndersonQ
changed the title
AndersonQ
force-pushed
the
5489-client-cert-key-passphrase
branch
from
cd98d59 to
2c94c5b
Compare
AndersonQ
commented
Sep 11, 2024
Comment on lines
+625
to
+626
| absPath, err := filepath.Abs("/path/to/token") | ||
| require.NoError(t, err, "could not get absolute absPath") |
There was a problem hiding this comment.
I honestly do not know why it was working on windows before, but it started to fail on elastic-agent-cert-key does not require key-passphrase, so I fixed all tests.
|
|
mergify
bot
added
the
backport-8.x
AndersonQ
force-pushed
the
5489-client-cert-key-passphrase
branch
from
cbdb682 to
1fa216d
Compare
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
It adds support for encrypted client certificate key during install/enroll, which done by the cli flag `--elastic-agent-cert-key-passphrase`.
ycombinator
force-pushed
the
5489-client-cert-key-passphrase
branch
from
c4dcbdf to
4d283ea
Compare
|
Merged
10 tasks
pierrehilbert
pushed a commit
that referenced
this pull request
Sep 23, 2024
…5494) (#5574) It adds support for encrypted client certificate key during install/enroll, which done by the cli flag `--elastic-agent-cert-key-passphrase`. (cherry picked from commit 346e5be) Co-authored-by: Anderson Queiroz <[email protected]>
belimawr
pushed a commit
to belimawr/elastic-agent
that referenced
this pull request
Sep 27, 2024
…lastic#5494) It adds support for encrypted client certificate key during install/enroll, which done by the cli flag `--elastic-agent-cert-key-passphrase`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It adds support for encrypted client certificate key during install/enroll, which done by the cli flag
--elastic-agent-cert-key-passphrase.Why is it important?
It enables Elastic Agent to be configured with passphrase-protected private keys for client mTLS certificates.
Checklist
[ ] I have made corresponding change to the default configuration files./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's checklist
Tests
--elastic-agent-cert-key-passphraseadheres to the same requirements as--fleet-server-cert-key-passphrase.--elastic-agent-cert-keyand--elastic-agent-certare provided when--elastic-agent-cert-key-passphraseis present.*enrollCmdOption.remoteConfig()accurately incorporates the passphrase intotlscommon.CertificateConfig.fleetclient.NewWithConfiggenerates a valid client capable of establishing an mTLS connection to a mock server.policy with SSL configto ensure the client certificate key passphrase from the cli is not left in the config when the policy's client client certificate key is not passphrase-protected.Disruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself